chore: lint more files #2470
Merged
chore: lint more files #2470
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 34 34
Lines 2998 2998
Branches 845 845
=======================================
Hits 2845 2845
Misses 150 150
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
negezor
pushed a commit
to negezor/vue-router
that referenced
this pull request
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several files that aren't currently being formatted by Prettier. I've tried to expand that to include more files.
mjsandmtsextensions.*.htmltolint-staged.lint:scriptto cover more files inpackages, as well asscripts.Changing the paths in
lint:scriptis probably the trickiest part. It's not entirely clear to me whether I've got those paths correct.It's worth noting that
lint-stageddoesn't take those paths into account, it just formats anything with the appropriate extensions. However, it only formats staged files, so anything in.gitignoreis implicitly ignored bylint-staged.Prettier 3 does take the root
.gitignoreinto account, but it doesn't consider nested.gitignorefiles, which are being used in this project. I needed to add the VitePress cache to.prettierignoreto account for that. Perhaps other files should be added too, but it wasn't clear to me what some of the things in the nested.gitignorefiles were.There are also 3 VitePress config files in this PR with minor formatting tweaks. These are files that are now picked up by
lint:scriptthat weren't previously. They should have already been picked up bylint-staged, but prior to #2466 that wasn't working for most people.